Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Alerts page #563

Open
wants to merge 1 commit into
base: ernest-/hdx-1303-tiles-alerting-ui
Choose a base branch
from
Open

feat: Alerts page #563

wants to merge 1 commit into from
+323 −14

Conversation

ernestii
Copy link
Contributor

@ernestii ernestii commented Jan 21, 2025 •
edited
Loading

Screenshot 2025-01-20 at 11 52 18 PM

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0708634

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ernestii ernestii force-pushed the ernest-/hdx-1303-tiles-alerting-ui branch 2 times, most recently from 052e209 to e7e9885 Compare January 21, 2025 05:48
@ernestii ernestii force-pushed the ernest-/hdx-1342-alerts-page branch 3 times, most recently from e49a387 to f7c2111 Compare January 21, 2025 05:52
wrn14897
wrn14897 reviewed Jan 22, 2025
View reviewed changes
packages/app/src/commonTypes.ts Outdated
@@ -64,6 +72,7 @@ export type SavedSearch = z.infer<typeof SavedSearchSchema>;
export const SavedChartConfigSchema = z.any();

export const TileSchema = z.object({
name: z.string().optional(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? name should be within config field, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, also removed commonTypes.ts from app package since I import everything from common utils now

wrn14897
wrn14897 reviewed Jan 22, 2025
View reviewed changes
packages/app/src/types.ts Outdated Show resolved Hide resolved
@ernestii ernestii force-pushed the ernest-/hdx-1303-tiles-alerting-ui branch 3 times, most recently from 0d4adc2 to b54104b Compare January 25, 2025 02:11
@ernestii ernestii force-pushed the ernest-/hdx-1342-alerts-page branch from f7c2111 to 2da65c0 Compare January 25, 2025 02:11
@ernestii ernestii force-pushed the ernest-/hdx-1303-tiles-alerting-ui branch 3 times, most recently from 9880cb2 to ae2dbdf Compare January 25, 2025 03:14
@ernestii ernestii force-pushed the ernest-/hdx-1342-alerts-page branch 2 times, most recently from 6818430 to e07e6ee Compare January 26, 2025 04:28
@ernestii ernestii requested a review from wrn14897 January 26, 2025 04:29
@ernestii ernestii force-pushed the ernest-/hdx-1342-alerts-page branch 2 times, most recently from c20bb94 to 7eea422 Compare January 26, 2025 04:40
@ernestii ernestii force-pushed the ernest-/hdx-1303-tiles-alerting-ui branch from f0c8364 to 6616f30 Compare January 26, 2025 04:46
@ernestii ernestii force-pushed the ernest-/hdx-1342-alerts-page branch from 7eea422 to 0708634 Compare January 26, 2025 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrn14897 wrn14897 Awaiting requested review from wrn14897

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ernestii @wrn14897