Improve encoder parameter configuration #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raccoonback
force-pushed
the
improve-encoder-parameters
branch
from
9d2300a to
6f3419f
Compare
raccoonback
force-pushed
the
improve-encoder-parameters
branch
from
6f3419f to
ed6e24d
Compare
hyperxpro
approved these changes
Dec 30, 2024
|
Thanks a lot! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Hello,
Currently, configuring
Encoder.Parametersrequires the following two steps:Encoder.Parametersobject.quality,lgwin, ormodeto configure it.This approach can be unnecessarily complex and may lack clarity.
Modification:
In this PR, I propose adding static methods to configure
Encoder.Parameterswithout explicitly creating an object.This makes the configuration process more intuitive and concise.
Result:
I believe this change will enhance code usability.
I would appreciate your review!
Thanks.