Implement new Input Capture protocol #7919
Conversation
| @@ -1,6 +1,7 @@ | |||
| [submodule "subprojects/hyprland-protocols"] | |||
| path = subprojects/hyprland-protocols | |||
| url = https://github.com/hyprwm/hyprland-protocols | |||
| url = https://github.com/3l0w/hyprland-protocols | |||
| branch = feat/input-capture-impl | |||
There was a problem hiding this comment.
marking this one as a blocker until this is removed so we dont forget (don't resolve)
3l0w
force-pushed
the
feat/input-capture-impl
branch
from
95c44f6 to
d22653e
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Idk when it will be finished. if you need it, build it yourself |
|
With your fork, will kvm software such as input leap work out of the box? |
|
Yes and i am it to test |
|
wow it was really troublesome compiling xdg-desktop-portal-hyprland. have to copy over the protocol to my /usr/share/hyprland-protocols(or clone it there), or i just removed the if line and forced it to get it from the repo. but, it seems to just fail in input-leap: it was giving a error that it cant find the input-leap location before installing your hyprland & xdg-desktop-portal-hyprland fork. that error is gone. but still failed. |
|
Its strange that you have to copy the protocol file over, did you clone the submodules ? ( |
its the cmakelist file, it tried to grab from /usr/share/hyprland-protocols if exist, which doesn't have your protocol as it's not merged in the hyprland-protocol repo, thus i made it only grab from the gh repo. i see, ill try that EDIT: in the install(from README: HOLLY! wow, not sure why, but i re-builded it and reinstalled it. and it WORKS! ty! A suggestion is that, disable this when mouse or keyboard is being capture/binded by programs(e.g. games that uses mouse to move camera) After two days of use. those are some feedbacks: this is what im using: but i have the following issues:
|
|
Thanks for the feedback tho i didn't encounter most of the issues you describe, but i will try to investigate it. |
|
alright. ty! Appreciate it! |
3l0w
force-pushed
the
feat/input-capture-impl
branch
from
29214bb to
189f615
Compare
|
The latest commit added a new shortcut: Personally, I bind it like this: |
|
Nice! I'm currently on vacation without my laptop, so I'll try it when I get back EDIT: Now i tried it, the new dispatcher works! ill try it when it locks down hyprland again and see if it works then |
if thats not possible then maybe add a dispatcher so user can script it to do so |
trim.44B51EBB-2916-40A4-BFBB-7EBA4AF42874.MOV |
You mean if a 3d game has kinda the mouse captured and move it to a border the input is captured and should not ? |
If you have any steps to reproduce it it will be great |
yes, for example my macbook is left, and i moved my cursor in game(that i captured) to left, it will eventually go to my mac screen. It does this in X11 too, but hoping it gets fixed as its unintended behavior and is very annoying since i have to quit my kvm software(input leap) in order to play games properly |
|
It is quite strange that you where able to still move the mouse in your primary computer. |
|
not sure, it just happend randomly, but before it happend, i was impl a new feature and was opening a nested Hyprland, but i wont try again today cuz it's pretty late and ill sleep |
related: https://www.reddit.com/r/kde/comments/u34lg0/wayland_gaming_and_mouse_capture/ |
|
ok mb it's my patch's issue |
|
Nah mb too, i need to send a frame after stop emulating i think |
multiple input-leap instances. maybe we shall only accpet one as... im not sure what would be the use case of multiple instance of any kvm software requetsing multiple instnaces of the protocol |
|
heres the logs... doesn't seem unusual. input-leap: xdph: |
3l0w
force-pushed
the
feat/input-capture-impl
branch
from
50fb494 to
f0a29c2
Compare
Nothing is said about that in the specs, maybe i will limit to one app being in the enable state |
|
I can't understand in your logs when it started to work again. Do you have smth like the time when i doesn't work anymore ? |
ya, it just randomly stopped working but log didn't say anything about that |
|
hmm... all of a sudden now the keybinds will trigger on the host even if mouse is captured on the client... |
|
I rebased maybe i broke something |
|
Okay i found why, i am pushing a fix |
Describe your PR, what does it fix/add?
This PR implements the input capture protocol defined in hyprwm/hyprland-protocols#8.
It also fixed a bug where
wl_output::geometryxandyarguments where always 0.The
wl_output::geometryevent is now sent when the output layout change (Help to followxandymodifications).Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
One bug that i found and i need to investigate, is when i capture every inputs,i can't shortcut into TTYs anymore.
Is it ready for merging, or does it need work?
It still need work, like sending the keyboard layout.