Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "disable_assets_check" #8788

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

MightyPlaza
Copy link
Contributor

adds "disable_assets_check"
hyprwm/hyprland-wiki#910

modified:   src/Compositor.cpp
modified:   src/config/ConfigManager.cpp
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

@MightyPlaza
Copy link
Contributor Author

Some users don't want to install the assets and don't want to have a patched version of Hyprland either
Alpine for example has a different package for the wallpapers

@vaxerski
Copy link
Member

vaxerski commented Dec 20, 2024

That's for wallpapers. What about crashed lock screens? I don't want people crying that the screen is black or whatever.

We can exclude the wallpaper check but other resources are important

@MightyPlaza
Copy link
Contributor Author

That's for wallpapers. What about crashed lock screens? I don't want people crying that the screen is black or whatever.

We can exclude the wallpaper check but other resources are important

they would still have to set the variable to true in the config, but in the end the user is probably the one that should choose what they want
another possibility could be a fallback lockscreen crash screen being added just with basic text rendering

@vaxerski
Copy link
Member

the user is probably the one that should choose what they want

the user is stupid more times than not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants