Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed weird size issue of 1st foot slave when set floating #8951

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

khushal-solves
Copy link
Contributor

@khushal-solves khushal-solves commented Jan 4, 2025

Describe your PR, what does it fix/add?

First slave window of foot terminal always had desired width = 14
Hyprland allowed all desired sizes with width & height greater than 5 so foot window saved 14 as width in last saved floating size.
So, later when this window is set floating it would have a width of 14 which looks very weird.

This only happens with 1st slave window of foot terminal, here is a video demo
I modified the code to allow all desired sizes with width & height more than 14.
Now, desired width 14 for first slave window of foot terminal becomes invalid and Hyprland resizes it appropriately. which looks normal as shown in this video

It relates to issue #8834 but i was only able to replicate the very tall and narrow window (when 1st slave is set floating) for foot terminal only

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

  • This only happens with foot terminal and that too with 1st slave window which is very weird.
  • Should this be treated as bug of foot terminal?
    Although minimum allowed size should be not related to how to different applications behave, width/height 14 is still very small. So it should not be allowed.

Is it ready for merging, or does it need work?

It requires review.

@vaxerski
Copy link
Member

vaxerski commented Jan 4, 2025

why does foot request width of 14?

@khushal-solves
Copy link
Contributor Author

Thanks, I will try to find the root cause.

@khushal-solves khushal-solves marked this pull request as draft January 5, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants