Fixed weird size issue of 1st foot slave when set floating #8951
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
First slave window of foot terminal always had desired width = 14
Hyprland allowed all desired sizes with width & height greater than 5 so foot window saved 14 as width in last saved floating size.
So, later when this window is set floating it would have a width of 14 which looks very weird.
This only happens with 1st slave window of foot terminal, here is a video demo
I modified the code to allow all desired sizes with width & height more than 14.
Now, desired width 14 for first slave window of foot terminal becomes invalid and Hyprland resizes it appropriately. which looks normal as shown in this video
It relates to issue #8834 but i was only able to replicate the very tall and narrow window (when 1st slave is set floating) for foot terminal only
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Although minimum allowed size should be not related to how to different applications behave, width/height 14 is still very small. So it should not be allowed.
Is it ready for merging, or does it need work?
It requires review.