Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: previous_per_monitor logic #9010

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: previous_per_monitor logic #9010

wants to merge 1 commit into from

Conversation

Truenya
Copy link
Contributor

@Truenya Truenya commented Jan 9, 2025

Describe your PR, what does it fix/add?

#6641
#6684

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

moved storage of previous workspaces relative to monitor to monitor class for dispatcher previous_per_monitor
also made some changes to CMakeLists to build successfully

Is it ready for merging, or does it need work?

ready for merge

@@ -290,7 +290,7 @@ endfunction()

target_link_libraries(Hyprland OpenGL::EGL OpenGL::GL Threads::Threads)

pkg_check_modules(hyprland_protocols_dep hyprland-protocols>=0.4.0)
pkg_check_modules(hyprland_protocols_dep hyprland-protocols>=0.5.0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wtf are these changes boss?

Copy link
Contributor Author

@Truenya Truenya Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this error occurred when building with version 0.4.0 (system version).

fixed it by using a higher version (this causes the build to fall back to the subproject)

[  2%] Built target libudis86
[  2%] Generating /home/true/my_builds/C++/HyprlandSrc/protocols/hyprland-ctm-control-v1.cpp, /home/true/my_builds/C++/HyprlandSrc/protocols/hyprland-ctm-control-v1.hpp
[  3%] Generating /home/true/my_builds/C++/HyprlandSrc/protocols/hyprland-focus-grab-v1.cpp, /home/true/my_builds/C++/HyprlandSrc/protocols/hyprland-focus-grab-v1.hpp
[  3%] Generating /home/true/my_builds/C++/HyprlandSrc/protocols/hyprland-global-shortcuts-v1.cpp, /home/true/my_builds/C++/HyprlandSrc/protocols/hyprland-global-shortcuts-v1.hpp
[  4%] Generating /home/true/my_builds/C++/HyprlandSrc/protocols/hyprland-surface-v1.cpp, /home/true/my_builds/C++/HyprlandSrc/protocols/hyprland-surface-v1.hpp
[  4%] Generating /home/true/my_builds/C++/HyprlandSrc/protocols/hyprland-toplevel-export-v1.cpp, /home/true/my_builds/C++/HyprlandSrc/protocols/hyprland-toplevel-export-v1.hpp
Couldn't load proto
gmake[3]: *** [CMakeFiles/Hyprland.dir/build.make:207: /home/true/my_builds/C++/HyprlandSrc/protocols/hyprland-surface-v1.cpp] 

Copy link
Contributor Author

@Truenya Truenya Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other edits in CMakeLists.txt had similar reasons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants