Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dispatchers: add documentation for fullscreenstate #892

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Buttars
Copy link

@Buttars Buttars commented Dec 4, 2024

This is a WIP and needs feedback to clarify a few things. Specifically whether fullscreen is planned for deprecation and the functionality of state 3 "maximize and fullscreen."

This is a WIP and needs feedback to clarify a few things. Specifically whether fullscreen is planned for deprecation and the functionality of state 3 "maximize and fullscreen."
@vaxerski
Copy link
Member

vaxerski commented Dec 5, 2024

then mark it as a wip

Specifically whether fullscreen is planned for deprecation

no

functionality of state 3 "maximize and fullscreen."

I actually dont know. @MightyPlaza maybe you know

@MightyPlaza
Copy link
Contributor

functionality of state 3 "maximize and fullscreen."

I actually dont know. @MightyPlaza maybe you know

it's just maximized and fullscreen, but for most (if not all) purposes it will behave the same as fullscreen

for dwindle and master (and likely all other layouts) internally is the same as just fullscreen
when set in the client side it shouldn't make any difference either, but the wayland protocols don't seem to forbid setting both
maybe it makes a difference in some program

@Buttars Buttars marked this pull request as draft January 5, 2025 11:07
@Buttars
Copy link
Author

Buttars commented Jan 5, 2025

@MightyPlaza I'm going to update the documentation to say that "maximize and fullscreen" will almost always work the same as fullscreen except in certain edge cases. Is it worth listing any edge cases?

@MightyPlaza
Copy link
Contributor

@MightyPlaza I'm going to update the documentation to say that "maximize and fullscreen" will almost always work the same as fullscreen except in certain edge cases. Is it worth listing any edge cases?

Not that I know of

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants