Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serde support for Height without revision_number #1397

Merged
merged 6 commits into from
Jan 28, 2025

Conversation

rnbguy
Copy link
Member

@rnbguy rnbguy commented Jan 27, 2025

Closes: #1262

Description

Makes revision_number field optional for Height struct when deserializing via serde -- specifically for JSON.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@rnbguy rnbguy requested a review from Farhad-Shabani January 27, 2025 17:13
@rnbguy rnbguy changed the title Rano/empty rev number in height fix: serde support for Height without revision_number Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.14%. Comparing base (a5f9fbf) to head (73698b0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1397   +/-   ##
=======================================
  Coverage   67.13%   67.14%           
=======================================
  Files         226      226           
  Lines       22455    22464    +9     
=======================================
+ Hits        15075    15083    +8     
- Misses       7380     7381    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on this and resolving it!

@Farhad-Shabani Farhad-Shabani added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 230e7a5 Jan 28, 2025
13 of 14 checks passed
@Farhad-Shabani Farhad-Shabani deleted the rano/empty-rev-number-in-height branch January 28, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wasm client fails to query TimestampAtHeight
2 participants