Don't throw when global is not defined
#45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`global` is not defined in some environments such as CF Workers and Vercel Edge Functions. Be defensive against that.
ljharb
approved these changes
Jun 22, 2024
There was a problem hiding this comment.
Typically my response to this category of thing is "this is a node module, which is designed to only be used in node, or via a working node module bundler" (eg, a working node module bundler transforms global as needed).
However, since this specific package doesn't have anything else node-specific besides uses of require, this is a reasonable change to accept.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
globalis not defined in some environments such as CF Workers and Vercel Edge Functions. Be defensive against that.