Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(ios, android): update v6 links #3990

Merged
merged 2 commits into from
Jan 9, 2025
Merged

docs(ios, android): update v6 links #3990

merged 2 commits into from
Jan 9, 2025

Conversation

thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Jan 6, 2025

Issue URL: resolves #3838

What is the current behavior?

Links that are pointing to v6 in the following structure are no longer redirecting correctly: /docs/v6. This is due to that version being archived, which causes the domain to change.

What is the new behavior?

Updated the links to the correct domain. I checked for other locations but this is only happening within two pages.

I considered making a global variable through the Docusaurus config but decided against it since it would only be used for 4 pages. We might also end up removing the reference in the next version.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Preview - iOS v8
Preview - Android v8
Preview - iOS v7
Preview - Android v7

Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 10:17pm

@thetaPC thetaPC marked this pull request as ready for review January 6, 2025 23:41
@thetaPC thetaPC requested a review from a team as a code owner January 6, 2025 23:41
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thetaPC thetaPC merged commit 8e44f7a into main Jan 9, 2025
4 checks passed
@thetaPC thetaPC deleted the ROU-11505 branch January 9, 2025 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: links to legacy developing guides are broken
2 participants