generated from ita-social-projects/DevTemplate
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add formula relations to calculators constructor #1006
Merged
olexandervanzuriak
merged 11 commits into
calculators-constructor
from
989-calculators-constructor-results-relations
Jan 25, 2025
Merged
Add formula relations to calculators constructor #1006
olexandervanzuriak
merged 11 commits into
calculators-constructor
from
989-calculators-constructor-results-relations
Jan 25, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## calculators-constructor #1006 +/- ##
===========================================================
+ Coverage 89.14% 89.36% +0.22%
===========================================================
Files 68 69 +1
Lines 1059 1081 +22
===========================================================
+ Hits 944 966 +22
Misses 115 115 ☔ View full report in Codecov by Sentry. |
loqimean
reviewed
Jan 3, 2025
loqimean
approved these changes
Jan 20, 2025
…9-calculators-constructor-results-relations
olexandervanzuriak
deleted the
989-calculators-constructor-results-relations
branch
January 25, 2025 12:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#989
Code reviewers
Summary of issue
Add relation to calculators constructor so that they looks similar to dippers calculator relations
Result
Added select input field on creating calculator constructor
Video.mp4
Results on show page
Video2.mp4
Summary of change
Added relation field to formula model and validations for it
CHECK LIST