Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add formula relations to calculators constructor #1006

Conversation

olexandervanzuriak
Copy link
Contributor

@olexandervanzuriak olexandervanzuriak commented Dec 11, 2024

#989

Code reviewers

Summary of issue

Add relation to calculators constructor so that they looks similar to dippers calculator relations

image

Result

Added select input field on creating calculator constructor

Video.mp4

Results on show page

Video2.mp4

Summary of change

Added relation field to formula model and validations for it

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • PR meets all conventions

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.36%. Comparing base (e558ac1) to head (a35c312).
Report is 1 commits behind head on calculators-constructor.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           calculators-constructor    #1006      +/-   ##
===========================================================
+ Coverage                    89.14%   89.36%   +0.22%     
===========================================================
  Files                           68       69       +1     
  Lines                         1059     1081      +22     
===========================================================
+ Hits                           944      966      +22     
  Misses                         115      115              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olexandervanzuriak olexandervanzuriak linked an issue Dec 12, 2024 that may be closed by this pull request
@olexandervanzuriak olexandervanzuriak merged commit 4c710b0 into calculators-constructor Jan 25, 2025
7 checks passed
@olexandervanzuriak olexandervanzuriak deleted the 989-calculators-constructor-results-relations branch January 25, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready for QA
Development

Successfully merging this pull request may close these issues.

Create result's relations
2 participants