-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove default value checks #852
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #852 +/- ##
==========================================
- Coverage 87.59% 87.57% -0.02%
==========================================
Files 128 128
Lines 11382 11383 +1
Branches 1540 1540
==========================================
- Hits 9970 9969 -1
- Misses 1025 1027 +2
Partials 387 387
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Deploying datachain-documentation with Cloudflare Pages
|
@@ -276,8 +276,9 @@ def has_table(self, name: str) -> bool: | |||
) | |||
return bool(next(self.execute(query))[0]) | |||
|
|||
def create_table(self, table: "Table", if_not_exists: bool = True) -> None: | |||
def create_table(self, table: "Table", if_not_exists: bool = True) -> "Table": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing this as it makes code better in Studio part where table columns are modified to allow nullable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Can we introduce something like |
Companion issue of https://github.com/iterative/studio/pull/11236
With making CH accept nullable columns, we no longer need special checks for default values in tests, as they will be
None
always.