Filter logging to hide massive stacktrace for access issue #857
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying datachain-documentation with
|
| Latest commit: |
f0723bf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://96f452de.datachain-documentation.pages.dev |
| Branch Preview URL: | https://amrit-filter-logging.datachain-documentation.pages.dev |
shcheklein
reviewed
Jan 24, 2025
| @@ -23,6 +24,10 @@ | |||
|
|
|||
| D = TypeVar("D", bound="DataChain") | |||
|
|
|||
| # Disable warnings for remote errors in clients | |||
| logging.getLogger("aiobotocore.credentials").setLevel(logging.CRITICAL) | |||
There was a problem hiding this comment.
how does logger settings affect stack traces?
|
I think the idea is not swallow things, but probably wrap into more meaningful messages / exceptions when possible. |
It doesn't swallow things but just disables the warnings or errors even when the exception has been raised for example : As a result, even when we capture the exception, we had the stacktrace in the terminal output. As for the original ask in the issue #600 , we can also print the stacktrace to the debug logger and print one line output if we want. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #857 +/- ##
=======================================
Coverage 87.59% 87.59%
=======================================
Files 128 128
Lines 11382 11385 +3
Branches 1540 1540
=======================================
+ Hits 9970 9973 +3
Misses 1025 1025
Partials 387 387
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@amritghimire okay, I see. thanks! |
shcheklein
approved these changes
Jan 25, 2025
Base automatically changed from
amrit/handle-permission-error-properly
to
main
January 27, 2025 06:25
With this change, we will return the ClientError without any extra error
or logs in the terminal. As a result, if we capture the ClientError in
the script, we will have minimum output.
Example query:
```python
from datachain.error import ClientError
from datachain.lib.dc import C, DataChain
try:
wds = (
DataChain.from_storage("az://amrit-datachain-test/shards")
.filter(C.name.glob("00000000.tar"))
.settings(parallel=8, cache=True)
)
wds.show()
except ClientError as e:
print(str(e))
print("Exception caught")
```
Closes #600
amritghimire
force-pushed
the
amrit/filter-logging
branch
from
2094c2c to
f0723bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main > #856 > #857 (this)
With this change, we will return the ClientError without any extra error
or logs in the terminal. As a result, if we capture the ClientError in
the script, we will have minimum output.
Example query:
Before changes:
After changes:
Closes #600