Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require exchange and grants directly #224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aufstrich
Copy link

direct require instead of fs.readDir allows oauth2orize to be packaged with webpack

@coveralls
Copy link

coveralls commented Apr 18, 2018

Coverage Status

Coverage decreased (-0.0009%) to 99.789% when pulling 31c331e on aufstrich:master into 3cd98f8 on jaredhanson:master.

@codyfyi
Copy link

codyfyi commented May 3, 2018

I assume fs is being used instead of require to allow extensions such as oauth2orize-openid to be loaded.

I ran into the same webpack issue though.

@gytisgreitai
Copy link

@aufstrich @codeitcody how have you solved it since it's not merged ? using a fork?

@codyfyi
Copy link

codyfyi commented Mar 25, 2019

@aufstrich @codeitcody how have you solved it since it's not merged ? using a fork?

I ended up just forking into my local project and made the modification. Not ideal but my need to webpack all my deps is going away so I didn't really work too hard at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants