-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avatar metadata for BitBucket organization folder is reworked #700
base: master
Are you sure you want to change the base?
Conversation
Since code is already has conditional branches for Server vs Cloud, handling of Avatar Metadata was split from single Action into two separate one. This enabled: * Deprecating the copypaste of Avatar caching logic. * Simplifying the BitBucket Cloud avatar metadata action * Re-working the BitBucket Server avatar metadata action to avoid capturing the copy of a credential.
@olamy @Dohbedoh can you check this out? It is not done but shows an alternative approach to Avatar loading that should work for all credential stores, not just system. |
I checked all the OSS plugins that depend on |
Thanks for your contribution <3 - would it be possible to fix the spotbugs issues? |
public final long lastModified; | ||
|
||
@Deprecated | ||
class AvatarImage extends jenkins.scm.impl.avatars.AvatarImage { |
Check notice
Code scanning / CodeQL
Class has same name as super class Note
jenkins.scm.impl.avatars.AvatarImage
@duemir Any chance you could finish this PR? |
@donkee I'd love to. I'm just finding it hard to get some focus time for the work. |
Can we somehow help? It's a constant source of pain for anyone with expiring tokens/passwords. |
Since code is already has conditional branches for Server vs Cloud, handling of Avatar Metadata was split from single Action into two separate one. This enabled:
Related to:
Your checklist for this pull request