Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Pytorch Lightning 2.0+ and make pip installable #14

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

saveriyo
Copy link

@saveriyo saveriyo commented Sep 4, 2024

(Upgrade from #9)

  • Upgrades to Pytorch Lightning 2.0+ and torch 2.0+
  • Adds pyproject.toml to be able to run pip install -e . or install direct from github and use the wavtokenizer module
  • Adds gitignore
  • Adds prepare_libritts.py to download, extract, and prep libritts for training

@saveriyo saveriyo force-pushed the feature/lightning-upgrade branch 2 times, most recently from 5e8cc50 to 9a10171 Compare September 6, 2024 15:44
@saveriyo saveriyo force-pushed the feature/lightning-upgrade branch from 9a10171 to 107c90c Compare September 11, 2024 17:53
@erogol
Copy link

erogol commented Sep 13, 2024

FYI getting errors in DDP training with your PR. I don't have the logs but it was similar to Lightning-AI/pytorch-lightning#18803

@saveriyo
Copy link
Author

Thank you @erogol , I applied a commit to revert to Lightning 2.0.9 which seems to work as suggested in the issue you linked. I also found I needed to set ddp_find_unused_parameters_true with this latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants