Introduce trackDepsWithReleaseAs to make trackDeps useable with releaseAs
#816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow users to use the trackDeps functionality when the releaseAs flag is being used as well.
lucavb
force-pushed
the
release-as-improvements
branch
from
93d27d8 to
d0a6456
Compare
|
Would love to see this included in a patch release very soon, as it solves a problem we (and others) are facing... |
4 tasks
|
@edbzn any particular reason why you closed this PR? Is there any other workaround to achieve this behaviour? |
|
Hey @lucavb, sorry I missed the notifications and have not been really active lately. The reason I closed this PR is that we already have too many options and we don't want to add an option for every new use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
this PR introduces a new configuration option,
trackDepsWithReleaseAs, which allows users to include dependencies in version bump calculations when using thereleaseAsoption. Currently, usingreleaseAsessentially disablestrackDepswhich was undesired behaviour for our use case. I believe this should also resolve this issue here.I also took the liberty of sorting some keys & prettier wanted to to format the README.md (only added some trailing commas). All three changes are in separate commits so they should be easily reviewable.