update test and add note

jsx-eslint · May 6, 2024 · 17aa88b · 17aa88b
1 parent 053a70a
commit 17aa88b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/__tests__/src/rules/no-interactive-element-to-noninteractive-role-test.js b/__tests__/src/rules/no-interactive-element-to-noninteractive-role-test.js
@@ -170,7 +170,6 @@ const alwaysValid = [
   { code: '<style role="button" />;' },
   { code: '<sub role="button" />;' },
   { code: '<summary role="button" />;' },
-  { code: '<summary role="listitem" />;' },
   { code: '<sup role="button" />;' },
   { code: '<th role="button" />;' },
   { code: '<time role="button" />;' },
@@ -373,6 +372,7 @@ const neverValid = [
   { code: '<select className="foo" role="listitem" />', errors: [expectedError] },
   { code: '<textarea className="foo" role="listitem" />', errors: [expectedError] },
   { code: '<tr role="listitem" />;', errors: [expectedError] },
+  { code: '<summary role="listitem" />;', errors: [expectedError] },
   /* Custom elements */
   { code: '<Link href="http://x.y.z" role="img" />', errors: [expectedError], settings: componentsSettings },
 ];

diff --git a/src/util/isInteractiveElement.js b/src/util/isInteractiveElement.js
@@ -96,7 +96,10 @@ function checkIsInteractiveElement(tagName, attributes): boolean {
   }
   // Check in elementAXObjects for AX Tree associations for this element.
   const isInteractiveAXElement = some(iterFrom(interactiveElementAXObjectSchemas), elementSchemaMatcher);
-  if (isInteractiveAXElement) {
+  if (
+    isInteractiveAXElement
+    || tagName === 'summary' // TODO: Remove this hard-coded addition once axobject-query is updated.
+  ) {
     return true;
   }