Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] no-autofocus: don't report error if autoFocus is set to false #1043

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

michaelfaith
Copy link
Contributor

This change adjusts the error condition for no-autofocus to allow for manually disabling autoFocus. Now, any usage of autoFocus="false" or autoFocus={false} will not report.

Closes: #1014

@michaelfaith michaelfaith force-pushed the patch/ignore-autofocus-false branch 2 times, most recently from 31b2212 to a7c3a37 Compare December 25, 2024 21:34
This change adjusts the error condition for `no-autofocus` to allow for manually disabling `autoFocus`.  Now, any usage of `autoFocus="false"` or `autoFocus={false}` will not report.
@michaelfaith michaelfaith force-pushed the patch/ignore-autofocus-false branch from a7c3a37 to 91e39b4 Compare December 25, 2024 21:41
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good

@michaelfaith michaelfaith marked this pull request as ready for review December 26, 2024 18:03
@ljharb ljharb merged commit 91e39b4 into jsx-eslint:main Dec 27, 2024
112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jsx-a11y/no-autofocus should not warn for false
2 participants