Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autofix-unused-prop-type #3725

Closed
wants to merge 1 commit into from

Conversation

Veveue
Copy link

@Veveue Veveue commented Apr 3, 2024

No description provided.

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.42%. Comparing base (e4ecbcf) to head (656ca95).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3725      +/-   ##
==========================================
- Coverage   97.76%   94.42%   -3.34%     
==========================================
  Files         133      133              
  Lines        9467     9477      +10     
  Branches     3467     3470       +3     
==========================================
- Hits         9255     8949     -306     
- Misses        212      528     +316     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljharb
Copy link
Member

ljharb commented Apr 4, 2024

It seems very dangerous to me to assume that it's safe to remove just because it's unused. Autofixing has a very high bar for when it's safe, and "removal" is generally not done with autofixes.

@Veveue
Copy link
Author

Veveue commented Apr 5, 2024

It seems very dangerous to me to assume that it's safe to remove just because it's unused. Autofixing has a very high bar for when it's safe, and "removal" is generally not done with autofixes.

I want to automatically fix many unnecessary imports caused by copying and pasting code.

@ljharb
Copy link
Member

ljharb commented Apr 5, 2024

Yes, but your desire to do less work doesn't mean the autofix is a safe thing to enable.

You could certainly implement this as a suggestion, though, if you like?

@Veveue
Copy link
Author

Veveue commented Apr 5, 2024

I understand. I will handle this issue locally. Thank you for your suggestion!

@Veveue Veveue closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants