Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rel/4.1.1 #257

Closed
wants to merge 3 commits into from
Closed

Rel/4.1.1 #257

wants to merge 3 commits into from

Conversation

ajaysubra
Copy link
Contributor

Description

While releasing RN for badge count noticed that it had a commit that relied on @dan-peluso's PR #236 being in swift so branching from the previous release tag 4.1.0 and cherry picking the above PR. Once released this branch will be deleted. Since this is just a staging branch, no intention to merge after release.

Check List

  • Are you changing anything with the public API?
  • Have you tested this change on real device?
  • Are your changes backwards compatible with previous SDK Versions?
  • Have you added unit test coverage for your changes?
  • Have you verified that your changes are compatible with all the operating system version this SDK currently supports?

Manual Test Plan

Supporting Materials

@ajaysubra ajaysubra requested a review from a team as a code owner January 22, 2025 05:17
Copy link
Contributor

@belleklaviyo belleklaviyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested the 4.1.2 TF build with this and looks good, thanks for catching this and handling it 🙏

@ajaysubra ajaysubra closed this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants