Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHNL-16220] FileIO changes #258

Merged
merged 9 commits into from
Jan 22, 2025
Merged

[CHNL-16220] FileIO changes #258

merged 9 commits into from
Jan 22, 2025

Conversation

ab1470
Copy link
Contributor

@ab1470 ab1470 commented Jan 22, 2025 •
edited
Loading

Description

This PR makes some changes to the FileIO enum:

  • it renames FileIO to ResourceLoader, as this object is responsible for reading resources within the app or framework bundle rather than managing files in the os filesystem
  • it adds handling for cases when the SDK is imported via Cocoapods. Previously there would be a compiler error because Cocoapods implementations cannot use Bundle.module.
  • it wraps ResourceLoader in #if DEBUG tags, because the ResourceLoader is currently only being used for Xcode previews.

Check List

  • Are you changing anything with the public API?
  • Have you tested this change on real device?
  • Are your changes backwards compatible with previous SDK Versions?
  • Have you added unit test coverage for your changes?
  • Have you verified that your changes are compatible with all the operating system version this SDK currently supports?

Manual Test Plan

  1. I've validated that the Xcode previews for KlaviyoWebViewController still work as expected

@ab1470 ab1470 requested a review from a team as a code owner January 22, 2025 06:12
ndurell
ndurell approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@ndurell ndurell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all test code correct?

@ab1470
Copy link
Contributor Author

ab1470 commented Jan 22, 2025

This is all test code correct?

Yes

@ab1470 ab1470 merged commit 432df3b into master Jan 22, 2025
14 checks passed
@ab1470 ab1470 deleted the ab/CHNL-16220/fileIO-changes branch January 22, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajaysubra ajaysubra ajaysubra approved these changes

@ndurell ndurell ndurell approved these changes

@belleklaviyo belleklaviyo Awaiting requested review from belleklaviyo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ab1470 @ndurell @ajaysubra