Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix cluster deletion when using BYO AWS infra mode and Secondary CIDR #5291

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adriananeci
Copy link

@adriananeci adriananeci commented Jan 20, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

Currently, cluster deletion is failing when using BYO AWS infra mode (https://cluster-api-aws.sigs.k8s.io/topics/bring-your-own-aws-infrastructure.html#tagging-aws-resources) with:

Events:
  Type     Reason                           Age                       From            Message
  ----     ------                           ----                      ----            -------
  Warning  FailedDisassociateSecondaryCidr  2m27s (x3471 over 3h21m)  aws-controller  (combined from similar events): Failed disassociating secondary CIDR "100.64.0.0/16" from VPC InvalidCidrBlock.InUse: The vpc vpc-021b2fd5f5a7df0bc currently has a subnet within CIDR block 100.64.0.0/16
           status code: 400, request id: fdddb61f-a01f-49ed-90a7-0489532ad351

While using the BYO AWS infra mode, VPC secondary CIDRs shouldn't be disassociated during cluster deletion.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Fix cluster deletion when using BYO AWS infra mode and Secondary CIDR

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 20, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 20, 2025
@adriananeci adriananeci changed the title Fix cluster deletion when using BYO AWS infra mode 🐛 Fix cluster deletion when using BYO AWS infra mode Jan 20, 2025
@adriananeci adriananeci changed the title 🐛 Fix cluster deletion when using BYO AWS infra mode 🐛 Fix cluster deletion when using BYO AWS infra mode and Secondary CIDR Jan 20, 2025
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 20, 2025
Copy link

@JonnieDoe JonnieDoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@JonnieDoe: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@AndiDog AndiDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants