Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix firstBucketSize for CPU histogram #7554

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix firstBucketSize for CPU histogram #7554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b5817a
Adjust cpuHistogramOptions
glemsom Dec 3, 2024
786e297
Bump SupportedCheckpointVersion
glemsom Dec 3, 2024
4dcb11d
Merge branch 'kubernetes:master' into fix-firstBucketSize
glemsom Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vertical-pod-autoscaler/pkg/recommender/model/aggregate_container_state.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const (
// Version id should be incremented on every non incompatible change, i.e. if the new
// version of the recommender binary can't initialize from the old checkpoint format or the
// previous version of the recommender binary can't initialize from the new checkpoint format.
SupportedCheckpointVersion = "v3"
SupportedCheckpointVersion = "v4"
)

var (
Expand Down
4 changes: 2 additions & 2 deletions vertical-pod-autoscaler/pkg/recommender/model/aggregations_config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,10 @@ func (a *AggregationsConfig) GetMemoryAggregationWindowLength() time.Duration {

func (a *AggregationsConfig) cpuHistogramOptions() util.HistogramOptions {
// CPU histograms use exponential bucketing scheme with the smallest bucket
// size of 0.01 core, max of 1000.0 cores and the relative error of HistogramRelativeError.
// size of 0.001 core, max of 1000.0 cores and the relative error of HistogramRelativeError.
//
// When parameters below are changed SupportedCheckpointVersion has to be bumped.
options, err := util.NewExponentialHistogramOptions(1000.0, 0.01, 1.+a.HistogramBucketSizeGrowth, epsilon)
options, err := util.NewExponentialHistogramOptions(1000.0, 0.001, 1.+a.HistogramBucketSizeGrowth, epsilon)
if err != nil {
panic("Invalid CPU histogram options") // Should not happen.
}
Expand Down
Loading