Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create dra-example-driver staging repo #7703

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Jan 21, 2025

This PR adds a staging repo to publish images built from https://github.com/kubernetes-sigs/dra-example-driver

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nojnhuh
Once this PR has been reviewed and has the lgtm label, please assign xmudrii for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/groups Google Groups management, code in groups/ area/infra Infrastructure management, infrastructure design, code in infra/ area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/registry.k8s.io Code in registry.k8s.io/ sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. labels Jan 21, 2025
@nojnhuh nojnhuh force-pushed the dra-example-driver-project branch from ee3ef38 to a47e42b Compare January 21, 2025 19:00
Comment on lines 56 to 62
members: # https://github.com/kubernetes-sigs/dra-example-driver/blob/main/OWNERS
- [email protected]
- [email protected]
- [email protected]
- [email protected]
- [email protected]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nojnhuh: what about adding yourself?

I certainly hope that you will continue to help with maintaining this! 😉

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep I can definitely add myself! Should I include myself in the OWNERS file added here too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added myself here but not in the OWNERS file, which I understand means something different.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to also have you there. If I remember correctly, we trigger image promotion by creating and updating files there. It seems reasonable to grant you the right to approve that when you also have permission to do that manually.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, done!

@nojnhuh nojnhuh force-pushed the dra-example-driver-project branch from a47e42b to 4baba73 Compare January 21, 2025 19:02
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2025
registries:
- name: gcr.io/k8s-staging-dra-example-driver
src: true
- name: asia-east1-docker.pkg.dev/k8s-artifacts-prod/images/dra-example-driver
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do all these registry names come from? How do we keep them up-to-date in the future?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally pulled this list from another image here: https://github.com/kubernetes/k8s.io/blob/4baba73c2b3c999fb7b217536981096bd3d0d83a/registry.k8s.io/manifests/k8s-staging-lws/promoter-manifest.yaml

Though it seems like the pattern from the cloud-provider-kind image here is slightly more up to date, so I've updated it here to match this: https://github.com/kubernetes/k8s.io/blob/14b4586d8809e2c12fd6847c0caad07c7b3168b8/registry.k8s.io/manifests/k8s-staging-cloud-provider-kind/promoter-manifest.yaml

That doesn't change the set of repos though, which I think sig-k8s-infra manages, e.g. #6322

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, so this is maintained my someone (in this case, probably literally one person). As long as it's not me I'm okay with this 😅

@nojnhuh nojnhuh force-pushed the dra-example-driver-project branch from 4baba73 to fd1fddb Compare January 22, 2025 17:50
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2025
@nojnhuh nojnhuh force-pushed the dra-example-driver-project branch from fd1fddb to a689190 Compare January 23, 2025 17:34
@k8s-ci-robot
Copy link
Contributor

@nojnhuh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-k8sio-cip a689190 link true /test pull-k8sio-cip

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@pohly pohly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pull-k8sio-cip failed, but with no information. Unrelated?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2025
@pohly
Copy link
Contributor

pohly commented Jan 24, 2025

/assign @xmudrii

For approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/groups Google Groups management, code in groups/ area/infra/gcp Issues or PRs related to Kubernetes GCP infrastructure area/infra Infrastructure management, infrastructure design, code in infra/ area/registry.k8s.io Code in registry.k8s.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants