-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create dra-example-driver staging repo #7703
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nojnhuh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ee3ef38
to
a47e42b
Compare
members: # https://github.com/kubernetes-sigs/dra-example-driver/blob/main/OWNERS | ||
- [email protected] | ||
- [email protected] | ||
- [email protected] | ||
- [email protected] | ||
- [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nojnhuh: what about adding yourself?
I certainly hope that you will continue to help with maintaining this! 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep I can definitely add myself! Should I include myself in the OWNERS file added here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added myself here but not in the OWNERS file, which I understand means something different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's fine to also have you there. If I remember correctly, we trigger image promotion by creating and updating files there. It seems reasonable to grant you the right to approve that when you also have permission to do that manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, done!
a47e42b
to
4baba73
Compare
registries: | ||
- name: gcr.io/k8s-staging-dra-example-driver | ||
src: true | ||
- name: asia-east1-docker.pkg.dev/k8s-artifacts-prod/images/dra-example-driver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do all these registry names come from? How do we keep them up-to-date in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I originally pulled this list from another image here: https://github.com/kubernetes/k8s.io/blob/4baba73c2b3c999fb7b217536981096bd3d0d83a/registry.k8s.io/manifests/k8s-staging-lws/promoter-manifest.yaml
Though it seems like the pattern from the cloud-provider-kind image here is slightly more up to date, so I've updated it here to match this: https://github.com/kubernetes/k8s.io/blob/14b4586d8809e2c12fd6847c0caad07c7b3168b8/registry.k8s.io/manifests/k8s-staging-cloud-provider-kind/promoter-manifest.yaml
That doesn't change the set of repos though, which I think sig-k8s-infra manages, e.g. #6322
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, so this is maintained my someone (in this case, probably literally one person). As long as it's not me I'm okay with this 😅
4baba73
to
fd1fddb
Compare
fd1fddb
to
a689190
Compare
@nojnhuh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
pull-k8sio-cip failed, but with no information. Unrelated?
/assign @xmudrii For approval. |
This PR adds a staging repo to publish images built from https://github.com/kubernetes-sigs/dra-example-driver