Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Create functional test for different KubevirtCI cluster configu… #1253

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: Create functional test for different KubevirtCI cluster configu… #1253

wants to merge 2 commits into from

Conversation

aerosouund
Copy link
Member

What this PR does / why we need it:

Creates a test script that covers more cases for kubevirtCI cluster configurations to improve bug detection

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign qinqon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Aug 23, 2024
@kubevirt-bot
Copy link
Contributor

Hi @aerosouund. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aerosouund aerosouund force-pushed the cluster-up-functional-test branch from 9c1a2ea to 35e4c1c Compare August 23, 2024 12:26
@aerosouund
test: Create functional test for different KubevirtCI cluster configu…
f3e8560 
…rations

This should run as a CI lane.
It will repetitively up and down clusters with the following features in the order they are named in

KSM and Swap
ETCD in memory
NFS CSI
Rook Ceph

Signed-off-by: aerosouund <[email protected]>
@aerosouund aerosouund force-pushed the cluster-up-functional-test branch from 35e4c1c to f3e8560 Compare August 23, 2024 12:43
@aerosouund aerosouund mentioned this pull request Aug 27, 2024
Merged
8 tasks
xpivarc
xpivarc reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@xpivarc xpivarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 points that come to my mind:

  1. Why don't we write Go test suite?
  2. We should add assert (specific to the option)

cluster-provision/k8s/check-cluster-opts.sh Outdated
Comment on lines 26 to 37
# Test KSM and Swap
export KUBEVIRT_KSM_ON="true"
export KUBEVIRT_KSM_SLEEP_BETWEEN_SCANS_MS=20
export KUBEVIRT_KSM_PAGES_TO_SCAN=10

export KUBEVIRT_SWAP_ON="true"
export KUBEVIRT_SWAP_SIZE_IN_GB=1

trap cleanup EXIT ERR SIGINT SIGTERM SIGQUIT
make cluster-up
${ksh} get nodes
make cluster-down
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably use new shell so the envs would be unset?

@aerosouund
test: Create ginkgo based functional testing suite
8f6e769 
Add tests for rook and nfs-csi and configure check cluster opts script to build ginkgo from vendor directory
and run the tests in separate shell environments

Signed-off-by: aerosouund <[email protected]>
@kubevirt-bot
Copy link
Contributor

@aerosouund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-up-kind-1.30-vgpu 8f6e769 link false /test check-up-kind-1.30-vgpu
check-up-kind-1.27-vgpu 8f6e769 link false /test check-up-kind-1.27-vgpu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kubevirt-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@kubevirt-bot kubevirt-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 21, 2024
@kubevirt-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@kubevirt-bot kubevirt-bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xpivarc xpivarc xpivarc left review comments

@brianmcarey brianmcarey Awaiting requested review from brianmcarey

@dhiller dhiller Awaiting requested review from dhiller

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aerosouund @kubevirt-bot @xpivarc