feat: Chipコンポーネントで背景色、ボーダー色、suffixアイコンを受け取れるようにする #5295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
https://smarthr.atlassian.net/browse/SHRUI-1216
概要
現状、Chipは文字サイズSのみで、背景色無し、borderもBORDERカラーしかなく、propsを受け取る設計になっていません。これはキャリア台帳でミニマムに使うために最低限の実装でリリースしたゆえの実装でした。
近々、プロダクト側で色をつけたりsuffixアイコンをつけたりしたいデザイン要件が出ているので、これに対応した形に改修します。
変更内容
確認方法
chromaticで確認してください。
https://63d0ccabb5d2dd29825524ab-gjalxjtfoy.chromatic.com/