Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: iframe内のコンテンツの高さを100%で表示できるように修正 #5319

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Qs-F
Copy link
Contributor

@Qs-F Qs-F commented Jan 22, 2025

関連URL

https://kufuinc.slack.com/archives/C079SGNTSGN/p1737529135300159?thread_ts=1737337547.918989&cid=C079SGNTSGN

https://kufuinc.slack.com/archives/C079SGNTSGN/p1737529430502409?thread_ts=1737337547.918989&cid=C079SGNTSGN

概要

Storybookの高さが不十分なことで、Dropdown等の外をクリックしたら閉じる系のものの挙動が勘違いされやすいので修正

変更内容

  • Storybookのiframeのhtml, bodyをheight: 100%に修正

before

2025-01-22.16.21.52.mov

after

2025-01-22.16.22.54.mov

確認方法

@Qs-F Qs-F requested a review from a team as a code owner January 22, 2025 07:23
@Qs-F Qs-F requested review from yt-ymmt and uknmr and removed request for a team January 22, 2025 07:23
Copy link

pkg-pr-new bot commented Jan 22, 2025

Open in Stackblitz

npm i https://pkg.pr.new/kufu/smarthr-ui@5319

commit: 13ee8df

@Qs-F
Copy link
Contributor Author

Qs-F commented Jan 22, 2025

VRTの差分、どこにでてるのかわからなかったのでレビューする方にお願いしたいです… (問題なければapproveしちゃってください)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant