Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add optional base path #39

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add optional base path #39

wants to merge 2 commits into from

Conversation

odama626
Copy link

@odama626 odama626 commented Apr 2, 2024

No description provided.

highb
highb requested changes Apr 3, 2024
View reviewed changes
setup-shared-env.sh Outdated
@@ -8,7 +8,7 @@ set -e
DEPLOY_REPO_URL="${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}"
echo "DEPLOY_REPO_URL=${DEPLOY_REPO_URL}" >> "${GITHUB_ENV}"

ENV_DIR="env/${ENV}"
ENV_DIR="${BASE_PATH}env/${ENV}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a slash here

@highb
Copy link
Contributor

highb commented Apr 3, 2024

I don't recall why, but the ENV_DIR is used as part of the ENV_BRANCH on line 14 in setup-shared-env.sh and branches can't have dots in them. So... you'll probably want to set the default base-path to an empty string.

@highb
Copy link
Contributor

highb commented Apr 3, 2024

Test showing the problem: https://github.com/kustomize-everything/action-env-build-and-deploy/actions/runs/8542467927/job/23404159358?pr=40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@highb highb highb requested changes

@codescene-delta-analysis codescene-delta-analysis[bot] codescene-delta-analysis[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odama626 @highb