Delay deletion of KAC #693
Open
+60
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de immediately but is scheduled for deletion later
…de immediately but is scheduled for deletion later Minor fixes to make the build pass Fixed tests for the coordinator Reverted an unneeded change in the test file
…into FTR-DelayKACDeletion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a datastream is deleted and its destination topic needs to be discarded, delay the deletion of the topic for an hour. This will allow all running instances to finish pumping messages to the topic. For now, this is all handled in memory, which means that if the leader coordinator is down before the KAC is deleted, the topic will remain alive. A possible integration with the Kafka GC or a simple ZK-backed GC for Brooklin is under consideration.