chore(http/retry): use boxed bodies instead of hyper::Body
#3515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
see #8733. the tests for the replay body use the `hyper::Body` type removed in the 1.0 release. this commit replaces this with `BoxBody` where possible, and adds comments with context about how to update code once upgrading to hyper 1.0. see #3467 and #3468 which added `from_static()` and `empty()`, respectively. Signed-off-by: katelyn martin <[email protected]>
sfleen
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see linkerd/linkerd2#8733.
the tests for the replay body use the
hyper::Bodytype removed in the 1.0 release.this commit replaces this with
BoxBodywhere possible, and adds comments with context about how to update code once upgrading to hyper 1.0.see #3467 and #3468 which added
from_static()andempty(), respectively.