Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing policy in the Prometheus federation #1887

Merged
merged 4 commits into from
Jan 13, 2025

Conversation

GTRekter
Copy link
Contributor

@GTRekter GTRekter commented Dec 2, 2024

GTRekter and others added 2 commits December 3, 2024 03:49
Author: Ivan (이반) Porta, Committer: GitHub
requiredAuthenticationRefs:
- group: policy.linkerd.io
kind: NetworkAuthentication
name: kubelet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we create this NetworkAuthentication when installing Linkerd? or is this something that we need to walk the reader through creating?

Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepting this because I think it's sound, although I have questions for engineering beyond this PR. 🙂

@kflynn
Copy link
Member

kflynn commented Jan 13, 2025

Forced DCO since @GTRekter is a Buoyant employee.

@kflynn kflynn merged commit 4d32ac6 into linkerd:main Jan 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants