[TOSA] Add lowering for aten.expm1 #3949
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Torch to TOSA legalization for aten.expm1 * Update xfail_sets with new test results * Add new LIT tests Signed-off-by: Justin Ngo <[email protected]> Change-Id: I834d0c7416341f884612053aebf9fcc90bcb3b53
sahas3
approved these changes
Jan 9, 2025
| // If input is not a float type then cast it to result element type | ||
| auto selfElemTy = selfType.getElementType(); | ||
| if (!isa<mlir::FloatType>(selfElemTy)) | ||
| self = tosa::promoteType(rewriter, self, resultType); |
There was a problem hiding this comment.
Do you know why there are tosaCastTensorToType and promoteType? tosaCastTensorToType seems to be a super-set of promoteType in terms of functionality -- so is there a need to maintain promoteType?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I834d0c7416341f884612053aebf9fcc90bcb3b53