[TOSA] TOSA 1.0 updates for LLVM hash 64edde66 #3978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TOSA 1.0 spec has a new pad shape for tosa.pad: https://www.mlplatform.org/tosa/tosa_spec.html#_pad * Update Torch to TOSA legalization for aten.constant_pad_nd according to the new shape in TOSA spec * Add new LIT test Signed-off-by: Justin Ngo <[email protected]> Change-Id: Id92eb342b7fbdb67c564acddb92c01eaf2e7b95a
* TOSA conv ops have a new acc_type attribute in TOSA 1.0 spec: https://www.mlplatform.org/tosa/tosa_spec.html#_conv2d * Add this new acc_type attribute to TOSA conv ops for aten.convolution legalization from Torch to TOSA * Add new LIT tests Signed-off-by: Justin Ngo <[email protected]> Change-Id: Ie32b4879d1e6070a9fd20b0aa04a54d79c025018
* Update tosa.tile with 'multiples' as an input of !tosa.shape instead of as an attribute. This is in alignment with TOSA 1.0 spec: https://www.mlplatform.org/tosa/tosa_spec.html#_tile * Add a temporary getTosaConstShape() function in TosaLegalizeUtils.h. This function will be removed when the permanent getTosaConstShape() function is available in mlir/include/mlir/Dialect/Tosa/Utils/ConversionUtils.h in a future LLVM bump in Torch-MLIR. * Update LIT tests Signed-off-by: Justin Ngo <[email protected]> Change-Id: I8c45160331d79e29b3df68cd74ad3bbd1b5a8042
|
@vivekkhandelwal1 This is the PR with all TOSA updates for the LLVM hash you are targeting. Please let me know if you want me to add/change anything. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Torch to TOSA legalizations with TOSA 1.0 ops' forms from LLVM hash 64edde66. Changes include: