fix: package exports and type definitions #8
Conversation
|
Hi @aryaemami59, Thank you very much for this PR. I am not a node expert and I would like to better understand and reproduce the issues. Which tool / command did you use to create the console output in the before / after screenshots? Best regards, |
|
@m31coding I used Are The Types Wrong, it's a very good tool, I also added it to the CI workflow. You can run it like this: npx @arethetypeswrong/cli@latest --pack |
| "types": "./dist/fuzzy-search.d.ts", | ||
| "default": "./dist/fuzzy-search.modern.js" | ||
| ".": { | ||
| "module-sync": { |
There was a problem hiding this comment.
How is "module-sync" used, what uses it? I have not seen this before.
There was a problem hiding this comment.
It's a new exports condition that allows for synchronously requiring an ESM file within CJS files.
package.json
Outdated
| }, | ||
| "scripts": { | ||
| "test": "jest --coverage", | ||
| "dev": "microbundle watch", | ||
| "build": "microbundle", | ||
| "build": "microbundle && cp dist/fuzzy-search.d.ts ./dist/fuzzy-search.d.cts", |
There was a problem hiding this comment.
I think this will not work on Windows. We could install cpx as a development dependency and use it instead of cp, what do you think?
There was a problem hiding this comment.
You're right it doesn't work on Windows. I fixed it in my latest commit if you wanna take a look.
|
@aryaemami59 PR is merged, thank you again for your contribution, very much appreciated! Best regards, |
This PR:
NodeNextmodule resolution.Before:
After: