haproxy: enable the Prometheus Exporter service #27442
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macportsbot
added
type: enhancement
maintainer: open
reneeotten
reviewed
Jan 23, 2025
net/haproxy/Portfile
Outdated
| variant promex description {Build with Prometheus Exporter service} { | ||
| build.args-append USE_PROMEX=1 | ||
| } | ||
|
|
There was a problem hiding this comment.
why does this need to be a variant? It doesn't appear to have any additional dependencies, so why not always enable it?
There was a problem hiding this comment.
I made it a variant because it's opt-in in "base" haproxy and opt-out in the nix package of haproxy.
But that's not a great reason; I'll make it always-on.
There was a problem hiding this comment.
but are you sure it doesn't need an external dependency?
There was a problem hiding this comment.
Yes:
- the top-level
Makefileadds only source and include paths inside the HAProxy repo - the
#includestatements inaddons/promexsource and header files) reference only files inside the HAProxy repo - and the nix package dependency list is invariant over
withPrometheusExporter(I'm totally cribbing from nix because I'm testing something locally that will run on NixOS in production)
Signed-off-by: Graham Reed <[email protected]>
greed42
force-pushed
the
haproxy_promex
branch
from
4755bf9 to
2fb665d
Compare
greed42
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
haproxy: enable the Prometheus Exporter service
Type(s)
Tested on
macOS 14.7.2 23H311 arm64
Xcode 16.2 16C5032a
Verification
Have you
port lint?sudo port test?sudo port -vst install?