Allow players to choose game configuration #260
+421
−305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marein
commented
Dec 4, 2024
| subscriptions="connect-four-{{ game.id }}{{ game.chatId ? ',chat-' ~ game.chatId }}" | ||
| {% if app.environment == 'dev' %}verbose{% endif %}> | ||
| </event-source> | ||
| <script type="module"> |
There was a problem hiding this comment.
Instead of this inline script, a sticky custom element should handle challenges. Basically like it was before, but a little bit more powerful, so users can navigate through the page.
marein
force-pushed
the
259-allow-players-to-choose-game-configuration
branch
28 times, most recently
from
c273bce to
1742016
Compare
marein
force-pushed
the
259-allow-players-to-choose-game-configuration
branch
11 times, most recently
from
1b6e428 to
ed43298
Compare
There was a problem hiding this comment.
Copilot reviewed 10 out of 26 changed files in this pull request and generated no suggestions.
Files not reviewed (16)
- assets/css/app.css: Language not supported
- config/connect-four/importmap.php: Language not supported
- src/ConnectFour/Application/Game/Command/OpenCommand.php: Language not supported
- src/ConnectFour/Application/Game/Command/OpenHandler.php: Language not supported
- src/ConnectFour/Domain/Game/Board/Size.php: Language not supported
- src/ConnectFour/Domain/Game/Board/Stone.php: Language not supported
- src/ConnectFour/Domain/Game/Configuration.php: Language not supported
- src/ConnectFour/Domain/Game/Event/GameAborted.php: Language not supported
- src/ConnectFour/Domain/Game/Event/GameOpened.php: Language not supported
- src/ConnectFour/Domain/Game/Event/PlayerJoined.php: Language not supported
- src/ConnectFour/Domain/Game/Game.php: Language not supported
- src/ConnectFour/Domain/Game/State/Open.php: Language not supported
- src/ConnectFour/Domain/Game/State/Running.php: Language not supported
- src/WebInterface/Presentation/Http/ConnectFourController.php: Language not supported
- src/WebInterface/Presentation/Http/Form/OpenType.php: Language not supported
- src/WebInterface/Presentation/Http/PageController.php: Language not supported
Comments skipped due to low confidence (2)
config/web-interface/services/controller.yml:4
- The '@twig' service is removed from the arguments list for the 'web-interface.page-controller'. If the controller relies on the Twig service for rendering views, this will cause runtime errors.
arguments: ['@connect-four.query-bus', '@web-interface.security']
config/web-interface/routing.yml:80
- The removal of the '_format: json' default may cause issues if the controller expects a JSON format. Ensure the controller can handle requests without this default or re-add it if necessary.
defaults: { _format: json }
9d131ee to
332a3ec
Compare
marein
commented
Dec 14, 2024
marein
force-pushed
the
259-allow-players-to-choose-game-configuration
branch
3 times, most recently
from
3826e1f to
f625ae7
Compare
marein
commented
Dec 18, 2024
| if ($width < 2 || $height < 2) { | ||
| throw new InvalidSizeException('Width and height must be greater then 1.'); | ||
| } | ||
|
|
||
| if (($width * $height) % 2 !== 0) { |
There was a problem hiding this comment.
That logic made sense because otherwise player 1 would have more moves than player 2. However, a 9x7 board size is valid according to Wikipedia.
marein
force-pushed
the
259-allow-players-to-choose-game-configuration
branch
from
f625ae7 to
26f1bfc
Compare
marein
commented
Jan 11, 2025
marein
force-pushed
the
259-allow-players-to-choose-game-configuration
branch
from
26f1bfc to
778beb6
Compare
marein
force-pushed
the
259-allow-players-to-choose-game-configuration
branch
2 times, most recently
from
f7bccb9 to
929c7bc
Compare
marein
force-pushed
the
259-allow-players-to-choose-game-configuration
branch
from
929c7bc to
6f5354d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests partially introduces a new concept, the challenge - described in #123, for views. It's not introducing the whole concept explicitly, otherwise the pull request would be too big.