Add JSON.document_root; test JSON and JSONSchema #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 92.73% 92.74% +0.01%
==========================================
Files 23 23
Lines 2052 2055 +3
Branches 435 436 +1
==========================================
+ Hits 1903 1906 +3
Misses 97 97
Partials 52 52
☔ View full report in Codecov by Sentry. |
This adds a generic document_root cached property to the JSON class, which can be distinct from both the document_schemaroot and resource_schemaroot of the JSONSchema class. This lays groundwork to support mixed content such as OpenAPI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements part of #108 (reply in thread) This adds a generic document_root cached property to the JSON class, which can be distinct from both the document_schemaroot and resource_schemaroot of the JSONSchema class.
This lays groundwork to support mixed content such as OpenAPI.