Apply suggestions from code review

Co-authored-by: Michal Kleiner <[email protected]>
matomo-org · Jan 17, 2025 · 2514ea5 · 2514ea5
1 parent 43c6436
commit 2514ea5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/core/DataTable/Row.php b/core/DataTable/Row.php
@@ -512,13 +512,13 @@ protected function getColumnAggregationOperation($columnNameOrId, $aggregationOp
         if (isset($aggregationOperations[$columnNameOrId])) {
             $operationName = $aggregationOperations[$columnNameOrId];
         } elseif (is_numeric($columnNameOrId)) {
-            // if the column was provided as index, check if a aggration is set for the real name
+            // if the column was provided as index, check if an aggregation is set for the real name
             $metricsIdToName = Metrics::getMappingFromIdToName();
             if (isset($metricsIdToName[$columnNameOrId]) && isset($aggregationOperations[$metricsIdToName[$columnNameOrId]])) {
                 $operationName = $aggregationOperations[$metricsIdToName[$columnNameOrId]];
             }
         } else {
-            // if the column was provided as string, check if a aggration is set for the index
+            // if the column was provided as string, check if an aggregation is set for the index
             $metricsNameToId = Metrics::getMappingFromNameToId();
             if (isset($metricsNameToId[$columnNameOrId]) && isset($aggregationOperations[$metricsNameToId[$columnNameOrId]])) {
                 $operationName = $aggregationOperations[$metricsNameToId[$columnNameOrId]];

diff --git a/plugins/API/ProcessedReport.php b/plugins/API/ProcessedReport.php
@@ -777,7 +777,7 @@ private function handleSimpleDataTable($idSite, $simpleDataTable, $metadataColum
         );
     }
 
-    private function aggregateReportTotalValues($simpleDataTable, $metadateColumns, $totals)
+    private function aggregateReportTotalValues($simpleDataTable, $metadataColumns, $totals)
     {
         $metadataTotals = $simpleDataTable->getMetadata('totalsUnformatted');
 
@@ -790,7 +790,7 @@ private function aggregateReportTotalValues($simpleDataTable, $metadateColumns,
         // remove columns from totals row that are not in metadata
         foreach ($metadataTotals as $metadataCol => $metadataValue) {
             if (
-                isset($metadateColumns[$metadataCol])
+                isset($metadataColumns[$metadataCol])
                 || preg_match('/^goal_[0-9]+_/', $metadataCol)
             ) {
                 $simpleTotals[$metadataCol] = $metadataValue;