Angular 19 #331
Open
Angular 19 #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxisam
reviewed
Jan 15, 2025
README.md
Outdated
| @@ -21,6 +21,7 @@ To make more sense with the future versioning scheme of Angular, the directive s | |||
| - If you need to use it on 9.x, please use version 13.x.x. | |||
| - If you need to use it on 10.x - 12.x, please use version 14.0.2. | |||
| - If you need to use it on 13.x, please use version 15.x.x. (Also thanks https://github.com/arturovt for updating & tuning) | |||
| - If you need to use it on 18.x, please use version 16.x.x. (Also thanks https://github.com/arturovt for updating & tuning) | |||
There was a problem hiding this comment.
do you wanna update the name to yours?
There was a problem hiding this comment.
yes can do tomorrow. can you check if it builds correctly?
|
I did run "ng lint --fix" and this somehow f'ed up the file encoding and stuff so it did not build/test/whatever. I reverted that. It should work fine now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I upgraded to Angular 19.
The tests wont start, idk.
But the demo app works