Add Dockerfile and patches for building Chromium with rav1d #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kkysen
reviewed
Oct 12, 2023
Comment on lines
+1
to
+13
| diff --git a/third_party/rust/rav1d/v1/crate/Cargo.toml b/third_party/rust/rav1d/v1/crate/Cargo.toml | ||
| --- a/third_party/rust/rav1d/v1/crate/Cargo.toml | ||
| +++ b/third_party/rust/rav1d/v1/crate/Cargo.toml | ||
| @@ -1,7 +1,7 @@ | ||
| [workspace] | ||
| members = [] | ||
| [package] | ||
| -name = "c2rust_out" | ||
| +name = "rav1d" | ||
| authors = ["C2Rust"] | ||
| -version = "0.0.0" | ||
| +version = "1.0.0" | ||
| publish = false |
There was a problem hiding this comment.
This part we can just modify in rav1d directly, right?
There was a problem hiding this comment.
Yeah, we probably should.
Merged
kkysen
added a commit
that referenced
this pull request
Oct 18, 2023
This just cleans up `Cargo.toml`, which was still mostly generated by `c2rust transpile`. The package is now named `rav1d` (like the `lib` was already changed to) and I set the version to `0.2.0` for future publishing (and so things like #519 don't need to patch it). The existing `rav1d` crate is at `0.1.0`, and so since we plan on publishing there, we can start at `0.2.0`. I also fixed some doc comments so `cargo test` can run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
then
xhost +on the host (TODO: get.Xauthorityto work) andor