-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improved site's web accessibility #2009
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: aakankshabhende <[email protected]>
✅ Deploy Preview for mesheryio-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The site's accessibility has been improved to 94 from 77. Below 2 issues will help us to improve score significantly-
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to stay with our brand colors and cannot deviate from the prescribed two tones of green color.
While the accessibility score has gone up with the changes in text size/logo size, the site's aesthetic appeal has gone down.
Yes, it is not a good user experience. |
Thank you for your contribution @aakankshabhende Add it as an agenda item to the meeting minutes, if you would. |
Description
This PR fixes #1983
Notes for Reviewers
The site's accessibility has been improved to 94 from 77. It can be improved further by fixing the colour contrast issue but as we are using the colour from our design system, I haven't changed it.
Signed commits