Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improved site's web accessibility #2009

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aakankshabhende
Copy link
Member

Description

This PR fixes #1983

Notes for Reviewers
The site's accessibility has been improved to 94 from 77. It can be improved further by fixing the colour contrast issue but as we are using the colour from our design system, I haven't changed it.

Signed commits

  • Yes, I signed my commits.

Signed-off-by: aakankshabhende <[email protected]>
Copy link

netlify bot commented Jan 2, 2025

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit cb0f01b
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/6776af0a8f95420008ca41ca
😎 Deploy Preview https://deploy-preview-2009--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aakankshabhende
Copy link
Member Author

The site's accessibility has been improved to 94 from 77.
It can be improved further by fixing the colour contrast issue but as we are using the colour from our design system, I haven't changed it.

Below 2 issues will help us to improve score significantly-

  1. Current colour - #00d3a9
    Colour that would help us pass atleast AA WCAG standard: #008571

BEFORE
image

AFTER
image

  1. Additionally, I haven't fixed the issue Heading elements are not in a sequentially-descending order in the LightHouse report as that is creating a significant UI change.

BEFORE
image

AFTER
image

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to stay with our brand colors and cannot deviate from the prescribed two tones of green color.

While the accessibility score has gone up with the changes in text size/logo size, the site's aesthetic appeal has gone down.

@aakankshabhende
Copy link
Member Author

Yes, it is not a good user experience.

@SAHU-01
Copy link
Contributor

SAHU-01 commented Jan 5, 2025

Thank you for your contribution @aakankshabhende
Let's discuss this during the website call on Monday(6th Jan 2025) at 6:30 PM IST

Add it as an agenda item to the meeting minutes, if you would.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Accessibility Improvement of the website
3 participants