Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop python<=3.7 support #163

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

drop python<=3.7 support #163

wants to merge 2 commits into from

Conversation

kloczek
Copy link

@kloczek kloczek commented Mar 10, 2024

According to https://endoflife.date/python python 3.7 has been EOSed in 27 Jun 2023.
Pass all code over pyupgrade --py3.8.

kloczek added 2 commits March 10, 2024 08:41
According to https://endoflife.date/python python 3.7 has been EOSed
in 27 Jun 2023.
Pass all code over `pyupgrade --py3.8`.

Signed-off-by: Tomasz Kłoczko <[email protected]>
@glensc
Copy link

glensc commented Oct 21, 2024

  1. never create pr from master branch
  2. you should also modify setup.py:
    python_requires='>=3.7',
  3. you should also update documentation, and ci. see 01d8e12

@kloczek
Copy link
Author

kloczek commented Oct 22, 2024

So against which one branch this PR should be created?

@glensc
Copy link

glensc commented Oct 22, 2024

I mean: don't use default branch in your repo: kloczek:master when creating PR. you can leave it as is for now, but note for the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants