Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Core Subnets Creation and upgrade core Terraform to 4.14.0 #4255

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

ShakutaiGit
Copy link
Collaborator

… in Terraform configurations

Resolves HASH_SIGN_FOLLOWED_BY_ISSUE_NUMBER

What is being addressed

Describe the current behavior you are modifying. Please also remember to update any impacted documentation.

How is this addressed

  • Describe the changes made, and if appropriate, why they are addressed this way
  • Note any pending work (with links to the issues that will address them)
  • Update documentation
  • Update CHANGELOG.md if needed
  • Increment template version if needed, for guidelines see Authoring templates - versioning

Copy link

github-actions bot commented Jan 6, 2025

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 99d695d.

♻️ This comment has been updated with latest results.

@ShakutaiGit ShakutaiGit changed the title Update Azure RM provider version and refactor subnet IP range filters… Update Core Subnet Creation and upgrade core Terraform to 4.14.0 Jan 6, 2025
@ShakutaiGit ShakutaiGit changed the title Update Core Subnet Creation and upgrade core Terraform to 4.14.0 Update Core Subnets Creation and upgrade core Terraform to 4.14.0 Jan 6, 2025
@ShakutaiGit
Copy link
Collaborator Author

/test-extended

Copy link

github-actions bot commented Jan 6, 2025

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12637008228 (with refid 1112296b)

(in response to this comment from @ShakutaiGit)

Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking this to ensure it doesn't get merged without upgrade considerations. But supportive if it works.

@ShakutaiGit
Copy link
Collaborator Author

/test-extended

Copy link

github-actions bot commented Jan 7, 2025

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12648030988 (with refid 1112296b)

(in response to this comment from @ShakutaiGit)

@ShakutaiGit
Copy link
Collaborator Author

/test-extended

Copy link

github-actions bot commented Jan 7, 2025

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12649874700 (with refid 1112296b)

(in response to this comment from @ShakutaiGit)

@ShakutaiGit
Copy link
Collaborator Author

/help

Copy link

github-actions bot commented Jan 7, 2025

🤖 pr-bot 🤖

Hello!

You can use the following commands:
    /test - build, deploy and run smoke tests on a PR
    /test-extended - build, deploy and run smoke & extended tests on a PR
    /test-extended-aad - build, deploy and run smoke & extended AAD tests on a PR
    /test-shared-services - test the deployment of shared services on a PR build
    /test-force-approve - force approval of the PR tests (i.e. skip the deployment checks)
    /test-destroy-env - delete the validation environment for a PR (e.g. to enable testing a deployment from a clean start after previous tests)
    /help - show this help

(in response to this comment from @ShakutaiGit)

@ShakutaiGit
Copy link
Collaborator Author

/test-destroy-env

Copy link

github-actions bot commented Jan 7, 2025

Destroying PR test environment (RG: rg-tre1112296b)... (run: https://github.com/microsoft/AzureTRE/actions/runs/12655217007)

Copy link

github-actions bot commented Jan 7, 2025

Destroying branch test environment (RG: rg-tre1dfa8de5)... (run: https://github.com/microsoft/AzureTRE/actions/runs/12655217007)

Copy link

github-actions bot commented Jan 7, 2025

Branch test environment destroy complete (RG: rg-tre1dfa8de5)

Copy link

github-actions bot commented Jan 7, 2025

PR test environment destroy complete (RG: rg-tre1112296b)

@ShakutaiGit
Copy link
Collaborator Author

/test-extended

Copy link

github-actions bot commented Jan 7, 2025

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12656026868 (with refid 1112296b)

(in response to this comment from @ShakutaiGit)

@ShakutaiGit
Copy link
Collaborator Author

/test-extended

Copy link

github-actions bot commented Jan 7, 2025

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12656575532 (with refid 1112296b)

(in response to this comment from @ShakutaiGit)

@ShakutaiGit
Copy link
Collaborator Author

/test-extended

Copy link

github-actions bot commented Jan 8, 2025

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/12669749201 (with refid 1112296b)

(in response to this comment from @ShakutaiGit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants