Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update torch.norm to torch.linalg.norm #6931

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

loadams
Copy link
Contributor

@loadams loadams commented Jan 8, 2025

Todo:

  • Update PR since torch.norm and torch.linalg.norm have different function signatures.
  • Check if there are any numeric differences between the functions.
  • Determine why there appear to be performance differences (nv-accelerate-v100 most notably: 2245.12s call tests/deepspeed/test_deepspeed.py::DeepSpeedConfigIntegration::test_basic_run)
  • Update to torch.linalg.matrixnorm or torch.linalg.vectornorm

@loadams loadams changed the title Apply fixes from torchfix Update torch.norm to torch.linalg.norm Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant