Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch gh (go-gh in vendor directory) to fix CVE-2024-53859 #11816

Open
wants to merge 2 commits into
base: 3.0-dev
Choose a base branch
from

Conversation

cyberbandya007
Copy link
Contributor

@cyberbandya007 cyberbandya007 commented Jan 8, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Patch gh (go-gh in vendor directory) to fix CVE-2024-53859

Change Log
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology
  • Pipeline build id: Buddy Build - 707155

@cyberbandya007 cyberbandya007 requested a review from a team as a code owner January 8, 2025 06:06
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Jan 8, 2025
SPECS/gh/gh.spec Outdated
@@ -25,10 +26,12 @@ Requires: git
GitHub official command line tool.

%prep
%autosetup -p1 -n cli-%{version}
# Don't patch during setup to apply vendor package 'go-gh' patch CVE-2024-53859.patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the CVE number and package name from comment. It's applicable for other CVEs and packages as well (For eg. I am fixed one in this PR: #11767)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0-dev PRs Destined for AzureLinux 3.0 Packaging