Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor config #1593

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor config #1593

wants to merge 2 commits into from

Conversation

dworthen
Copy link
Contributor

@dworthen dworthen commented Jan 8, 2025

  • Add new ModelConfig to represent LLM settings
    • Combines LLMParameters, ParallelizationParameters, encoding_model, and async_mode
  • Add top level models config that is a list of available LLM ModelConfigs
  • Remove LLMConfig inheritance and delete LLMConfig
    • Replace the inheritance with a model_id reference to the ModelConfig listed in the top level models config
  • Remove all fallbacks and hydration logic from create_graphrag_config
    • This removes the automatic env variable overrides
  • Support env variables within config files using Templating
    • This requires "$" to be escaped with extra "$" so ".\.txt$" becomes ".\.txt$$"
  • Update init content to initialize new config file with the ModelConfig structure

Checklist

  • I have tested these changes locally.
  • I have reviewed the code changes.
  • I have updated the documentation (if necessary).
  • I have added appropriate unit tests (if applicable).

Additional Notes

[Add any additional notes or context that may be helpful for the reviewer(s).]

- Add new ModelConfig to represent LLM settings
    - Combines LLMParameters, ParallelizationParameters, encoding_model, and async_mode
- Add top level models config that is a list of available LLM ModelConfigs
- Remove LLMConfig inheritance and delete LLMConfig
    - Replace the inheritance with a model_id reference to the ModelConfig listed in the top level models config
- Remove all fallbacks and hydration logic from create_graphrag_config
    - This removes the automatic env variable overrides
- Support env variables within config files using Templating
    - This requires "$" to be escaped with extra "$" so ".*\\.txt$" becomes ".*\\.txt$$"
- Update init content to initialize new config file with the ModelConfig structure
@dworthen dworthen requested review from a team as code owners January 8, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant