CVM: Updated traces to log by default, unless trace is tagged with CVM_CONFIDENTIAL #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smalis-msft
reviewed
Dec 17, 2024
… for those marked as CVM_CONFIDENTIAL
jazzybluesea
force-pushed
the
users/sewong/cvm_allowed
branch
from
4a5d652 to
c58accd
Compare
smalis-msft
reviewed
Dec 17, 2024
| pub fn confidential_event_filter<S: Subscriber>() -> impl Filter<S> { | ||
| FilterFn::new(move |m| m.fields().field("CVM_ALLOWED").is_some()) | ||
| FilterFn::new(move |m| m.fields().field("CVM_CONFIDENTIAL").is_some().not()) |
There was a problem hiding this comment.
Definitely not. The design here was intentional. We can not allow un-audited tracing statements to be logged in a CVM.
There was a problem hiding this comment.
The auditing will be done during code review correct? Given that most of the traces are not confidential, it is easier to maintain if we change it to behave this way.
There was a problem hiding this comment.
The problem is all the tracing statements that already exist that may log sensitive or confidential information. The auditing needs to be opt-in on a per-statement level. I agree that this would be easier, but it is also an unacceptable level of risk to meet our CVM confidentiality guarantees.
jazzybluesea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.