Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playground RIR tab with raw and ssa processed RIR #2096

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

idavis
Copy link
Collaborator

@idavis idavis commented Jan 7, 2025

No description provided.

@idavis idavis self-assigned this Jan 7, 2025
@idavis idavis marked this pull request as ready for review January 7, 2025 21:46
compiler/qsc/src/codegen.rs Show resolved Hide resolved
wasm/src/lib.rs Show resolved Hide resolved
compiler/qsc/src/codegen.rs Outdated Show resolved Hide resolved
compiler/qsc/src/codegen.rs Outdated Show resolved Hide resolved
@minestarks
Copy link
Member

@idavis just noticed that the RIR tab doesn't show errors like the QIR tab does. RIR will just continue to show the last successful result which can be frustrating. Maybe you forgot to wire up the error handling somehow?

@idavis
Copy link
Collaborator Author

idavis commented Jan 14, 2025

Waiting for #2098 to merge first.

@idavis idavis force-pushed the iadavis/rir-playground-tab branch from 14e63bb to 36c5fe1 Compare January 14, 2025 18:12
@idavis idavis enabled auto-merge January 14, 2025 18:12
@idavis idavis added this pull request to the merge queue Jan 14, 2025
Merged via the queue into main with commit c6d74f6 Jan 14, 2025
18 checks passed
@idavis idavis deleted the iadavis/rir-playground-tab branch January 14, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants