Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Teams chef bot sample cannot debug in Test Tool after local debugging #2241

Closed
tecton opened this issue Dec 19, 2024 · 1 comment · Fixed by #2240
Closed

[Bug]: Teams chef bot sample cannot debug in Test Tool after local debugging #2241

tecton opened this issue Dec 19, 2024 · 1 comment · Fixed by #2240
Assignees
@aycabas
Labels
bug Something isn't working

Comments

@tecton
Copy link
Member

tecton commented Dec 19, 2024

Language

Javascript/Typescript

Version

latest

Description

The environment variables in ".env" file will cause Test Tool not working. It's configured in teamsapp.local.yml file.

Reproduction Steps

1.Clone the sample.
2. Select "Debug (Edge)" and press "F5".
3. Stop debugging and Select "Debug in Test Tool".
4. The Test Tool will show authentication error.
5. Click "Provision" and then "Deploy".
6. Select "Launch Remote (Edge)" and press "F5".
7. bot is not responding.
@tecton tecton added the bug Something isn't working label Dec 19, 2024
@tecton tecton mentioned this issue Dec 19, 2024
Merged
1 task
@corinagum
Copy link
Collaborator

Assigning to @aycabas since I have asked her to review the PR

corinagum added a commit that referenced this issue Jan 8, 2025
@tecton @corinagum
[JS] fix: local debug environment variables location in teams chef bo…
3d26bea 
…t sample (#2240)

## Linked issues

closes: #2241 

## Details

Provide a list of your changes here. If you are fixing a bug, please
provide steps to reproduce the bug.
1. Fix bug that debugging in test tool is not working after local
debugging.
  a. Clone the sample.
  b. Select "Debug (Edge)" and press "F5".
  c. Stop debugging and Select "Debug in Test Tool".
  d. The Test Tool will show authentication error.
2. Fix the outdated lines in README file.

#### Change details

Environment variables like bot id and password will be read from
.localConfigs in npm script.
So the env file update in teamsapp.local.yml should be ".localConfigs".
Writing to ".env" file will pollute the Test Tool environment.

> Describe your changes, with screenshots and code snippets as
appropriate

**code snippets**:

**screenshots**:

## Attestation Checklist

- [ ] My code follows the style guidelines of this project

- I have checked for/fixed spelling, linting, and other errors
- I have commented my code for clarity
- I have made corresponding changes to the documentation (updating the
doc strings in the code is sufficient)
- My changes generate no new warnings
- I have added tests that validates my changes, and provides sufficient
test coverage. I have tested with:
  - Local testing
  - E2E testing in Teams
- New and existing unit tests pass locally with my changes

### Additional information

> Feel free to add other relevant information below

---------

Co-authored-by: Corina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aycabas aycabas

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[JS] fix: local debug environment variables location in teams chef bot sample tecton/teams-ai
3 participants
@tecton @corinagum @aycabas